Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finer grained netty dependencies #276

Merged
merged 1 commit into from
May 17, 2023

Conversation

Nashatyrev
Copy link
Collaborator

Follow up to #274 (comment)

'Umbrella' artifact netty-all transitively includes a lot of unneeded Netty dependencies.
It's better to have finer grained Netty artifacts dependencies

@Nashatyrev Nashatyrev marked this pull request as ready for review May 16, 2023 10:22
Copy link
Collaborator

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev Nashatyrev merged commit e7d633e into libp2p:v1.0.0 May 17, 2023
@Nashatyrev
Copy link
Collaborator Author

Part of #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants